drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #843: DRILL-5533: Fix flag assignment in FunctionInitiali...
Date Tue, 23 May 2017 15:29:36 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/843#discussion_r118021635
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionInitializer.java
---
    @@ -31,29 +31,25 @@
     import org.codehaus.janino.Scanner;
     import org.mortbay.util.IO;
     
    -import com.google.common.collect.Maps;
    -
     /**
      * To avoid the cost of initializing all functions up front,
    - * this class contains all informations required to initializing a function when it is
used.
    + * this class contains all information required to initializing a function when it is
used.
      */
     public class FunctionInitializer {
    -  static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(FunctionInitializer.class);
    +  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(FunctionInitializer.class);
     
       private final String className;
       private final ClassLoader classLoader;
    -  private Map<String, CompilationUnit> functionUnits = Maps.newHashMap();
    --- End diff --
    
    Is this map unused?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message