drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Date Mon, 22 May 2017 17:44:19 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r117804950
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java
---
    @@ -497,6 +510,21 @@ public int numResizing() {
         return numResizing;
       }
     
    +  /**
    +   *
    +   * @return Size of extra memory needed if the HT (i.e. startIndices) is doubled
    +   */
    +  @Override
    +  public int extraMemoryNeededForResize() {
    --- End diff --
    
    Good observation !! Fixed .....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message