drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #832: DRILL-5504: Vector validator to diagnose offset vec...
Date Thu, 18 May 2017 22:59:47 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/832#discussion_r117359430
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java
---
    @@ -69,9 +70,18 @@ public static RootExec getExec(FragmentContext context, FragmentRoot
root) throw
         Preconditions.checkNotNull(root);
         Preconditions.checkNotNull(context);
     
    -    if (AssertionUtil.isAssertionsEnabled()) {
    +    // Enable iterator (operator) validation if assertions are enabled (debug mode)
    +    // or if in production mode and the ENABLE_ITERATOR_VALIDATION option is set
    +    // to true.
    +
    +    boolean enableValidation = AssertionUtil.isAssertionsEnabled();
    +    if (! enableValidation) {
    +      enableValidation = context.getOptionSet().getOption(ExecConstants.ENABLE_ITERATOR_VALIDATOR);
    +    }
    +    if (enableValidation) {
    --- End diff --
    
    Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message