drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #839: DRILL-5516: Use max allowed allocated memory when d...
Date Wed, 17 May 2017 21:13:27 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/839#discussion_r117110883
  
    --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
---
    @@ -187,8 +189,8 @@ public int next() {
         }
     
         int rowCount = 0;
    -    done:
    -    for (; rowCount < TARGET_RECORD_COUNT; rowCount++) {
    +    // if first row is larger than allowed max size in batch, it will be added anyway
    +    do {
    --- End diff --
    
    Still need to monitor row count: row count cannot exceed 64K. So, loop termination is
either exceeds memory limit OR reaches max row count. For row count, might as well use the
original limit, unless we know enough to pick a better limit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message