drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Date Wed, 17 May 2017 21:00:56 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r117104008
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java
---
    @@ -99,17 +100,31 @@ public void setCost(double cost) {
         this.cost = cost;
       }
     
    -  // Not available. Presumably because Drill does not currently use
    -  // this value, though it does appear in some test physical plans.
    -//  public void setMaxAllocation(long alloc) {
    -//    maxAllocation = alloc;
    -//  }
    -
       @Override
       public long getMaxAllocation() {
         return maxAllocation;
       }
     
    +  /**
    +   * Any operator that supports spilling should override this method
    +   * @param maxAllocation The max memory allocation to be set
    +   */
    +  @Override
    +  public void setMaxAllocation(long maxAllocation) {
    --- End diff --
    
    There was a problem with this method, which is why it was commented out. Trying to remember...
Something about the internal, temporary serializations in planning causing values to be overwritten.
Jackson will see this method and use it for deserializing the value. May have to fiddle around
a bit to remember the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message