drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Date Wed, 17 May 2017 21:00:56 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r117105800
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/AggPrelBase.java
---
    @@ -51,7 +51,7 @@
     
     public abstract class AggPrelBase extends DrillAggregateRelBase implements Prel {
     
    -  protected static enum OperatorPhase {PHASE_1of1, PHASE_1of2, PHASE_2of2};
    +  public static enum OperatorPhase {PHASE_1of1, PHASE_1of2, PHASE_2of2};
    --- End diff --
    
    Nit, but enum values are constants and so convention is all upper case: maybe: PHASE1OF2
or PHASE1_OF_2 or PHASE_1_OF_2...
    
    Not a big deal; the current form is a bit easier to read...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message