drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Date Wed, 17 May 2017 21:00:56 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r117102340
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -86,6 +92,19 @@
     
       BooleanValidator EXTERNAL_SORT_DISABLE_MANAGED_OPTION = new BooleanValidator("exec.sort.disable_managed",
false);
     
    +  // Hash Aggregate Options
    +
    +  String HASHAGG_NUM_PARTITIONS_KEY = "drill.exec.hashagg.num_partitions";
    --- End diff --
    
    For config options, the path is usually "drill.exec.something". But, for system/session
options, there is no need for the top "drill." namespace, so they usually are of the form
"exec.something" or even shorter. Check out some of the other names and you'll see the pattern.
    
    Or, am I confused? Normally, the option name appears as "key", then a validator, using
that name, appears below. But, in the validator, we have a different name (one that does,
in fact, follow the usual option rules.) So, we we have both a config and a system/session
option?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message