drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Date Wed, 17 May 2017 21:00:56 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r117106759
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/MemoryAllocationUtilities.java
---
    @@ -40,7 +39,7 @@
        * @param plan
        * @param queryContext
        */
    -  public static void setupSortMemoryAllocations(final PhysicalPlan plan, final QueryContext
queryContext) {
    +  public static void setupBufferedOpsMemoryAllocations(final PhysicalPlan plan, final
QueryContext queryContext) {
    --- End diff --
    
    This change looks good. Very clean.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message