drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #835: DRILL-5399: Fix race condition in DrillComplexWrite...
Date Mon, 15 May 2017 22:39:16 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/835#discussion_r116611004
  
    --- Diff: logical/src/main/java/org/apache/drill/common/expression/FunctionHolderExpression.java
---
    @@ -28,6 +28,7 @@
     public abstract class FunctionHolderExpression extends LogicalExpressionBase {
       public final ImmutableList<LogicalExpression> args;
       public final String nameUsed;
    +  private FieldReference ref;
    --- End diff --
    
    Maybe explain this a bit. After looking at all the changes, I can see that something called
a "ref" is now passed along. But, nothing here explains what that "ref" is. Maybe put a Javadoc
here to explain the purpose of the ref. Then, the other changes will be clearer.
    
    That is, "A field reference identifies the __(what?)__ used to reference the __(what?)__
in a __(what?)__ expression." Is this the reference to a field in the generate code that holds
the value of the function? A field that holds the function instance? Something else?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message