drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #833: DRILL-5496: Fix for failed Hive connection
Date Mon, 15 May 2017 18:32:41 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/833#discussion_r116559151
  
    --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java
---
    @@ -105,6 +105,20 @@ private boolean needToImpersonateReadingData() {
         return isDrillImpersonationEnabled && isHS2DoAsSet;
       }
     
    +  /**
    +   * Close this schema factory in preparation for retrying. Attempt to close
    +   * connections, but just ignore any errors.
    +   */
    +
    +  public void close() {
    +    try {
    +      processUserMetastoreClient.close();
    +    } catch (Exception e) { }
    --- End diff --
    
    No real need. The problem is not that the close fails for whatever reason, it is higher
up in the food chain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message