drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill issue #819: DRILL-5419: Calculate return string length for literals & ...
Date Fri, 12 May 2017 17:38:37 GMT
Github user jinfengni commented on the issue:

    https://github.com/apache/drill/pull/819
  
    I agreed with @paul-rogers  that BatchSchema and MaterializedField should consider all
fields (I once briefly mentioned to @paul-rogers I feel there might be bug in the equals/hashCode
methods). 
    
    Regarding Paul's 3 point, if we can get the schema infor (varchar length) from data, i.e.
the underneath storage plugin (RDBMS) provides such information, when Drill gets the batch
from recordReader, then Arina's patch will work the same way as as the input is a string literal.
In that sense, the work in this patch is complimentary to how we know the table column's varchar
length. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message