drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #827: DRILL-5481: Persist profiles in-memory only with a ...
Date Tue, 09 May 2017 18:20:52 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/827#discussion_r115563669
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/LocalPersistentStoreProvider.java
---
    @@ -57,14 +59,14 @@ public LocalPersistentStoreProvider(final DrillConfig config) throws
StoreExcept
       }
     
       @Override
    -  public <V> PersistentStore<V> getOrCreateStore(PersistentStoreConfig<V>
storeConfig) {
    +  public <V> PersistentStore<V> getOrCreateStore(PersistentStoreConfig<V>
storeConfig) throws StoreException {
         switch(storeConfig.getMode()){
         case BLOB_PERSISTENT:
         case PERSISTENT:
    -      if (enableWrite) {
    +      if (!useEphemeral) {
    --- End diff --
    
    I've actually refactored the internal unit tests that leveraged this flag. It doesn't
seem to be used outside of the tests.
    I think the enableWrite is a little misleading. We already have a skipWritingProfiles
flag introduced. Do you really think there is a backward compatibility that would be broken,
considering this was hidden away in a 'test' package?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message