drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ppadma <...@git.apache.org>
Subject [GitHub] drill pull request #827: DRILL-5481: Persist profiles in-memory only with a ...
Date Tue, 09 May 2017 13:37:52 GMT
Github user ppadma commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/EphemeralPersistentStore.java
    @@ -93,6 +107,14 @@ public void put(final String key, final V value, final DataChangeVersion
             throw new VersionMismatchException("Version mismatch detected", dataChangeVersion.getVersion());
           store.put(key, value);
    +      currentSize.incrementAndGet();
    +      if (currentSize.get() > maxCapacity) {
    +        //Pop Out Oldest
    +        ((ConcurrentSkipListMap<String, V>) store).pollLastEntry();
    --- End diff --
    should this be pollFirstEntry() ?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message