drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #823: DRILL-5459: Extend physical operator test framework...
Date Fri, 05 May 2017 23:24:37 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/823#discussion_r115102606
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java ---
    @@ -307,19 +308,43 @@ public void close() throws Exception {
       }
     
       /**
    +   * Iterate over batches, and combine the batches into a map, where key is schema path,
and value is
    +   * the list of column values across all the batches.
    --- End diff --
    
    Thanks for adding the Javadoc comments! Very helpful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message