drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Date Wed, 03 May 2017 21:32:25 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r114360302
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcEncoder.java ---
    @@ -111,7 +111,7 @@ protected void encode(ChannelHandlerContext ctx, OutboundRpcMessage
msg, List<Ob
             cos.writeRawVarint32(rawBodyLength);
             cos.flush(); // need to flush so that dbody goes after if cos is caching.
     
    -        CompositeByteBuf cbb = new CompositeByteBuf(buf.alloc(), true, msg.dBodies.length
+ 1);
    +        final CompositeByteBuf cbb = ctx.alloc().compositeBuffer(msg.dBodies.length +
1);
    --- End diff --
    
    Same as above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message