drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #821: DRILL-5450: Fix initcap function to convert upper c...
Date Tue, 02 May 2017 05:11:39 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/821#discussion_r114249334
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
---
    @@ -308,4 +308,58 @@ public void testReverseLongVarChars() throws Exception {
           FileUtils.deleteQuietly(path);
         }
       }
    +
    +  @Test
    +  public void testLower() throws Exception {
    +    testBuilder()
    +        .sqlQuery("select\n" +
    +            "lower('ABC') col_upper,\n" +
    +            "lower('abc') col_lower,\n" +
    --- End diff --
    
    Please add tests for Greek and Cyrillic. Our source encoding is UTF-8, so you can enter
the characters directly. Or, if that does not work, you can instead use the Java Unicode encoding:
U1234.
    
    If the tests fail because of parsing of SQL, please file a bug. If they fail because the
function above does not support UTF-8, please file a different bug.
    
    In either case, you can then comment out the test cases and add a comment that says that
they fail due to DRILL-xxxx, whatever your bug number turns out to be.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message