drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Date Mon, 01 May 2017 23:07:59 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r114211502
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java
---
    @@ -243,4 +249,46 @@ public SaslMessage process(SaslChallengeContext context) throws Exception
{
           }
         }
       }
    +
    +  private static void handleSuccess(SaslChallengeContext context) throws SaslException
{
    +    final ClientConnection connection = context.connection;
    +    final SaslClient saslClient = connection.getSaslClient();
    +
    +    try {
    +      // Check if connection was marked for being secure then verify for negotiated QOP
value for
    +      // correctness.
    +      final String negotiatedQOP = saslClient.getNegotiatedProperty(Sasl.QOP).toString();
    --- End diff --
    
    Hmm, I read that in [Sasl.QOP doc](http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/8u40-b25/javax/security/sasl/Sasl.java#85):
    
    > ... If this property is absent, the default qop is "auth"....
    
    So the change is required?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message