Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: sudheeshkatkam <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-773-drill@git.apache.org>
In-Reply-To: <git-pr-773-drill@git.apache.org>
Subject: [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Content-Type: text/plain
Message-Id: <20170405221949.0CAD0E968D@git1-us-west.apache.org>
Date: Wed,  5 Apr 2017 22:19:48 +0000 (UTC)
archived-at: Wed, 05 Apr 2017 22:19:55 -0000

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r109971454
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/AbstractRemoteConnection.java ---
    @@ -34,16 +37,26 @@
       private final WriteManager writeManager;
       private final RequestIdMap requestIdMap = new RequestIdMap();
       private final String clientName;
    -
       private String name;
     
    +  // Encryption related parameters
    +  private EncryptionContext encryptionContext;
    +  // SaslBackendWrapper to hold instance of SaslClient/SaslServer
    +  protected SaslBackendWrapper saslBackend;
    +
       public AbstractRemoteConnection(SocketChannel channel, String name) {
         this.channel = channel;
         this.clientName = name;
         this.writeManager = new WriteManager();
    +    this.encryptionContext = new EncryptionContext();
         channel.pipeline().addLast(new BackPressureHandler());
       }
     
    +  public AbstractRemoteConnection(SocketChannel channel, String name, EncryptionContext encryptionContext) {
    +    this(channel, name);
    +    this.encryptionContext.initialize(encryptionContext);
    --- End diff --
    
    To avoid `initialize`, call this ctor from the other one and move other inits here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---