drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #819: DRILL-5419: Calculate return string length for lite...
Date Tue, 25 Apr 2017 15:27:19 GMT
GitHub user arina-ielchiieva opened a pull request:


    DRILL-5419: Calculate return string length for literals & some string…

    … functions
    1. Revisited calculation logic for string literals and some string functions (cast, upper,
lower, initcap, reverse, concat, concat operator, substring, substr, left, right, rpad, lpad,
case statement, coalesce, first_value, last_value).
    2. Deprecated width and changed it to precision for string types.
    3. Synchronized return type length calculation logic between limit 0 and regular queries.
    4. Performed minor refactoring, added appropriate unit tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arina-ielchiieva/drill DRILL-5419

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #819
commit c7ec21bc1caa02587f6b748ee6e213b78e916cb6
Author: Arina Ielchiieva <arina.yelchiyeva@gmail.com>
Date:   2017-04-06T10:44:26Z

    DRILL-5419: Calculate return string length for literals & some string functions


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message