drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #808: DRILL-5325: Unit tests for the managed sort
Date Thu, 06 Apr 2017 20:57:40 GMT
GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/808

    DRILL-5325: Unit tests for the managed sort

    Uses the sub-operator test framework (DRILL-5318), including the test
    row set abstraction (DRILL-5323) to enable unit testing of the
    “managed” external sort. This PR allows early review of the code, but
    cannot be pulled until the dependencies (mentioned above) are pulled.
    
    Refactors the external sort code into small chunks that can be unit
    tested, then “wraps” that code in tests for all interesting data types,
    record batch sizes, and so on.
    
    Refactors some of the operator definitions to more easily allow
    programmatic setup in the unit tests.
    
    Fixes a number of bugs discovered by the unit tests. The biggest
    changes were in the new code: the code that computes spilling and
    merging based on memory levels.
    
    Otherwise, although GitHub will show many files change, most of the
    changes are simply moving blocks of code around to create smaller units
    that can be tested independently.
    
    Includes a refactoring of the code that does spilling, along with a
    complete set of low-level unit tests.
    
    Since this PR is dependent on others, it cannot (yet) be built on its
    own. The PR will be rebased once the dependencies are in master so that
    it will build prior to commit to master.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-5325

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/808.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #808
    
----
commit ccd0f15889b8cc7ec1011a7a7f8126b16c6bbf40
Author: Paul Rogers <progers@maprtech.com>
Date:   2017-04-06T20:57:19Z

    DRILL-5325: Unit tests for the managed sort
    
    Uses the sub-operator test framework (DRILL-5318), including the test
    row set abstraction (DRILL-5323) to enable unit testing of the
    “managed” external sort. This PR allows early review of the code, but
    cannot be pulled until the dependencies (mentioned above) are pulled.
    
    Refactors the external sort code into small chunks that can be unit
    tested, then “wraps” that code in tests for all interesting data types,
    record batch sizes, and so on.
    
    Refactors some of the operator definitions to more easily allow
    programmatic setup in the unit tests.
    
    Fixes a number of bugs discovered by the unit tests. The biggest
    changes were in the new code: the code that computes spilling and
    merging based on memory levels.
    
    Otherwise, although GitHub will show many files change, most of the
    changes are simply moving blocks of code around to create smaller units
    that can be tested independently.
    
    Includes a refactoring of the code that does spilling, along with a
    complete set of low-level unit tests.
    
    Since this PR is dependent on others, it cannot (yet) be built on its
    own. The PR will be rebased once the dependencies are in master so that
    it will build prior to commit to master.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message