drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #819: DRILL-5419: Calculate return string length for lite...
Date Fri, 28 Apr 2017 01:29:31 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillStringLeftRightFuncHolder.java
    @@ -0,0 +1,72 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to you under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.expr.fn;
    +import org.apache.drill.common.expression.LogicalExpression;
    +import org.apache.drill.common.expression.ValueExpressions;
    +import org.apache.drill.common.types.TypeProtos;
    +import org.apache.drill.common.types.Types;
    +import org.apache.drill.exec.expr.fn.impl.StringFunctionHelpers;
    +import java.util.List;
    + * Function holder for functions with function scope set as
    + * {@link org.apache.drill.exec.expr.annotations.FunctionTemplate.FunctionScope#STRING_LEFT_RIGHT}.
    + */
    +public class DrillStringLeftRightFuncHolder extends DrillSimpleFuncHolder  {
    +  public DrillStringLeftRightFuncHolder(FunctionAttributes functionAttributes, FunctionInitializer
initializer) {
    +    super(functionAttributes, initializer);
    +  }
    +  /**
    +   * Defines function return type and calculates output precision.
    --- End diff --
    Nit. That you've added comments is already a huge win. To make the generated Javadoc appear
nicely, and to help us Eclipse users (Eclipse generated formatted Javadoc when we hover the
cursor over the class or method name), please remember to include any needed HTML formatting
tags, such as <p> between paragraphs, <br> at non-paragraph newlines -- you know
the drill. Thanks!

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message