drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #819: DRILL-5419: Calculate return string length for lite...
Date Thu, 27 Apr 2017 21:30:08 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/819#discussion_r113804343
  
    --- Diff: protocol/src/main/protobuf/Types.proto ---
    @@ -70,8 +70,8 @@ enum MinorType {
     message MajorType {
       optional MinorType minor_type = 1;
       optional DataMode mode = 2;
    -  optional int32 width = 3; // optional width for fixed size values.
    -  optional int32 precision = 4; // used for decimal types
    +  optional int32 width = 3;
    +  optional int32 precision = 4; // used for decimal types or as optional length for fixed
size values
    --- End diff --
    
    optional length for "fixed" size value? 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message