drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #819: DRILL-5419: Calculate return string length for lite...
Date Thu, 27 Apr 2017 21:30:08 GMT
Github user jinfengni commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
    @@ -512,9 +511,9 @@ public LogicalExpression visitLiteral(RexLiteral literal) {
             return ValueExpressions.getBit(((Boolean) literal.getValue()));
           case CHAR:
             if (isLiteralNull(literal)) {
    -          return createNullExpr(MinorType.VARCHAR);
    +          return createStringNullExpr(literal.getType().getPrecision());
    --- End diff --
    what is the length for literal "NULL"?  

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message