drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #819: DRILL-5419: Calculate return string length for lite...
Date Thu, 27 Apr 2017 16:17:40 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/819#discussion_r113605192
  
    --- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
    @@ -27,10 +27,14 @@
     import org.apache.drill.common.types.TypeProtos.MinorType;
     
     import com.google.protobuf.TextFormat;
    +import org.apache.drill.common.util.CoreDecimalUtility;
     
     public class Types {
       static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(Types.class);
     
    +  public static final int MAX_VARCHAR_LENGTH = 65536;
    --- End diff --
    
    65535? Largest that will fit in 16 bits?
    
    Actually, why is this the limit? Is there any technical reason we can't handle, say, 1
MB strings?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message