drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Date Wed, 26 Apr 2017 02:36:43 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r113351684
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java
---
    @@ -243,4 +249,46 @@ public SaslMessage process(SaslChallengeContext context) throws Exception
{
           }
         }
       }
    +
    +  private static void handleSuccess(SaslChallengeContext context) throws SaslException
{
    +    final ClientConnection connection = context.connection;
    +    final SaslClient saslClient = connection.getSaslClient();
    +
    +    try {
    +      // Check if connection was marked for being secure then verify for negotiated QOP
value for
    +      // correctness.
    +      final String negotiatedQOP = saslClient.getNegotiatedProperty(Sasl.QOP).toString();
    +      final String expectedQOP = connection.isEncryptionEnabled()
    +          ? SaslProperties.QualityOfProtection.PRIVACY.getSaslQop()
    +          : SaslProperties.QualityOfProtection.AUTHENTICATION.getSaslQop();
    +
    +      if (!(negotiatedQOP.equals(expectedQOP))) {
    +        throw new SaslException(String.format("Mismatch in negotiated QOP value: %s and
Expected QOP value: %s",
    +            negotiatedQOP, expectedQOP));
    +      }
    +
    +      // Update the rawWrapChunkSize with the negotiated buffer size since we cannot
call encode with more than
    +      // negotiated size of buffer.
    +      if (connection.isEncryptionEnabled()) {
    +        final int negotiatedRawSendSize = Integer.parseInt(
    +            saslClient.getNegotiatedProperty(Sasl.RAW_SEND_SIZE).toString());
    +        if (negotiatedRawSendSize <= 0) {
    +          throw new SaslException(String.format("Negotiated rawSendSize: %d is invalid.
Please check the configured " +
    +              "value of sasl.encryption.encodesize. It might be configured to a very
small value.",
    +              negotiatedRawSendSize));
    +        }
    +        connection.setWrapSizeLimit(negotiatedRawSendSize);
    --- End diff --
    
    Please fix naming (or maybe I am easily confused).
    
    wrapSizeLimit and negotiatedRawSendSize, contrast with maxRawWrapSize in SaslEncryptionHandler.
All of which are actually `maxSendBufferSize` per documentation in Sasl.RAW_SEND_SIZE.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message