drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Date Wed, 26 Apr 2017 02:36:40 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r112788779
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RemoteConnection.java ---
    @@ -51,6 +51,12 @@
     
       SocketAddress getRemoteAddress();
     
    +  void addSecurityHandlers();
    +
    +  void incConnectionCounter();
    --- End diff --
    
    Remove this increment and decrement counters from the interface; these methods are invoked
on implementations. 
    
    Maybe empty protected methods in `AbstractRemoteConnection` with impls in concrete classes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message