drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Date Mon, 17 Apr 2017 07:42:23 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r111646590
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java
---
    @@ -243,4 +247,43 @@ public SaslMessage process(SaslChallengeContext context) throws Exception
{
           }
         }
       }
    +
    +  private static void handleSuccess(SaslChallengeContext context) throws SaslException
{
    +    final ClientConnection connection = context.connection;
    +    final SaslClient saslClient = connection.getSaslClient();
    +
    +    if (connection.isEncrypted()) {
    +      try {
    +        // Check if connection was marked for being secure then verify for negotiated
QOP value for
    +        // correctness.
    +        final String negotiatedQOP = saslClient.getNegotiatedProperty(Sasl.QOP).toString();
    +        assert (negotiatedQOP.equals(SaslProperties.QualityOfProtection.PRIVACY.getSaslQop()));
    +
    +        // Update the rawWrapChunkSize with the negotiated buffer size since we cannot
call encode with more than
    +        // negotiated size of buffer.
    +        final int negotiatedRawSendSize = Integer.parseInt(saslClient
    +                                                            .getNegotiatedProperty(SaslProperties.WRAP_RAW_SEND_SIZE)
    --- End diff --
    
    thanks for catching this... not sure why I didn't spotted it earlier. That's why I declared
a new constant in SaslProperties. Changed to use Sasl.RAW_SEND_SIZE


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message