drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #805: Drill-4139: Exception while trying to prune partiti...
Date Thu, 13 Apr 2017 23:09:56 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/805#discussion_r111505132
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
    @@ -508,7 +511,10 @@ public void populatePruningVector(ValueVector v, int index, SchemaPath
column, S
             NullableVarBinaryVector varBinaryVector = (NullableVarBinaryVector) v;
             Object s = partitionValueMap.get(f).get(column);
             byte[] bytes;
    -        if (s instanceof Binary) {
    +        if (s == null) {
    +          varBinaryVector.getMutator().setNull(index);
    --- End diff --
    
    Should we apply this setNull() to all other types? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message