drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vvysotskyi <...@git.apache.org>
Subject [GitHub] drill pull request #815: DRILL-5424: Fix IOBE for reverse function
Date Thu, 13 Apr 2017 13:30:24 GMT
Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/815#discussion_r111389438
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
---
    @@ -273,4 +273,13 @@ public void testSplit() throws Exception {
             .run();
       }
     
    +  @Test
    +  public void testReverse() throws Exception {
    +    testBuilder()
    +      .sqlQuery("select reverse(reverse(n_comment)) words from cp.`tpch/nation.parquet`")
    +      .unOrdered()
    +      .sqlBaselineQuery("select n_comment words from cp.`tpch/nation.parquet`")
    +      .build()
    +      .run();
    +  }
    --- End diff --
    
    Thanks, added these both tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message