drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #787: DRILL-5319: Refactor "contexts" for unit testing
Date Thu, 06 Apr 2017 18:42:23 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/787#discussion_r110235334
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
    @@ -90,19 +90,19 @@ public void validate(final OptionValue v, final OptionManager manager)
{
       }
     
       public static class MinRangeDoubleValidator extends RangeDoubleValidator {
    -    private final double min;
    -    private final double max;
    +//    private final double min;
    --- End diff --
    
    Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message