drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Date Wed, 05 Apr 2017 22:19:52 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r110035581
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java
---
    @@ -335,8 +350,27 @@ public BitToUserHandshake getHandshakeResponse(UserToBitHandshake
inbound) throw
                 }
               }
     
    -          // mention server's authentication capabilities
    -          respBuilder.addAllAuthenticationMechanisms(config.getAuthProvider().getAllFactoryNames());
    +          // We are checking in UserConnectionConfig that if SASL encryption is enabled
then mechanisms other
    +          // than PLAIN are also configured otherwise throw exception
    +          final Set<String> configuredMech = config.getAuthProvider().getAllFactoryNames();
    +
    +          if (!config.isEncryptionEnabled()) {
    +
    +            respBuilder.addAllAuthenticationMechanisms(configuredMech);
    +          } else {
    --- End diff --
    
    Few things to note:
    + If encryption is enabled, PLAIN will fail negotiation anyway. So the special handling
(and this block itself) is unnecessary?
    + An implication of this is that even if the Drillbit starts up with PLAIN configured
correctly, the mechanism will not be offered to clients.
    + Consider a custom mechanism which do not support encryption, PLAIN will not be offered,
but that mechanism will be offered?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message