drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Date Wed, 05 Apr 2017 22:19:52 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r109729986
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -116,6 +116,11 @@
       String BIT_AUTHENTICATION_ENABLED = "drill.exec.security.bit.auth.enabled";
       String BIT_AUTHENTICATION_MECHANISM = "drill.exec.security.bit.auth.mechanism";
       String USE_LOGIN_PRINCIPAL = "drill.exec.security.bit.auth.use_login_principal";
    +  String USER_SASL_ENCRYPTION_ENABLED = "drill.exec.security.user.sasl.encryption.enabled";
    --- End diff --
    
    How about using "drill.exec.security.user.**encryption.sasl**.enabled" instead of "drill.exec.security.user.**sasl.encryption**.enabled"
to be consistent with "auth" (and similarly below)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message