drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...
Date Wed, 05 Apr 2017 22:19:48 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r109968323
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java
---
    @@ -135,20 +137,33 @@ public void submitQuery(UserResultsListener resultsListener, RunQuery
query) {
        * @param credentials credentials
        * @throws RpcException if either connection or authentication fails
        */
    -  public void connect(final DrillbitEndpoint endpoint, final DrillProperties properties,
    -                      final UserCredentials credentials) throws RpcException {
    -    final UserToBitHandshake handshake = UserToBitHandshake.newBuilder()
    +  public void connect(final DrillbitEndpoint endpoint, final DrillProperties properties,
final UserCredentials credentials) throws RpcException {
    +    final UserToBitHandshake.Builder hsBuilder = UserToBitHandshake.newBuilder()
             .setRpcVersion(UserRpcConfig.RPC_VERSION)
             .setSupportListening(true)
             .setSupportComplexTypes(supportComplexTypes)
             .setSupportTimeout(true)
             .setCredentials(credentials)
             .setClientInfos(UserRpcUtils.getRpcEndpointInfos(clientName))
    -        .setSaslSupport(SaslSupport.SASL_AUTH)
    -        .setProperties(properties.serializeForServer())
    -        .build();
    +        .setSaslSupport(SaslSupport.SASL_PRIVACY)
    +        .setProperties(properties.serializeForServer());
    +
    +    // Only used for testing purpose
    +    if (properties.containsKey(DrillProperties.TEST_OLD_CLIENT)) {
    --- End diff --
    
    Although only VisibleForTesting, this property is still available to any user. Could this
cause trouble?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message