drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #785: DRILL-5323: Test tools for row sets
Date Tue, 14 Mar 2017 23:18:44 GMT
GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/785

    DRILL-5323: Test tools for row sets

    Provide test tools to create, populate and compare row sets
    
    To simplify tests, we need a TestRowSet concept that wraps a
    VectorContainer and provides easy ways to:
    
    - Define a schema for the row set.
    - Create a set of vectors that implement the schema.
    - Populate the row set with test data via code.
    - Add an SV2 to the row set.
    - Pass the row set to operator components (such as generated code
    blocks.)
    - Examine the contents of a row set
    - Compare the results of the operation with an expected result set.
    - Dispose of the underling direct memory when work is done.
    
    This code builds on that in DRILL-5324 to provide a complete row set
    API. See DRILL-5318 for the spec.
    
    Note: this code can be reviewed as-is, but cannot be committed until
    after DRILL-5324 is committed: this code has compile-time dependencies
    on that code. This PR will be rebased once DRILL-5324 is pulled into
    master.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-5323

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/785.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #785
    
----
commit 99b3ed45eed41907a143ece7082b8af926bd920b
Author: Paul Rogers <progers@maprtech.com>
Date:   2017-03-14T23:18:24Z

    DRILL-5323: Test tools for row sets
    
    Provide test tools to create, populate and compare row sets
    
    To simplify tests, we need a TestRowSet concept that wraps a
    VectorContainer and provides easy ways to:
    
    - Define a schema for the row set.
    - Create a set of vectors that implement the schema.
    - Populate the row set with test data via code.
    - Add an SV2 to the row set.
    - Pass the row set to operator components (such as generated code
    blocks.)
    - Examine the contents of a row set
    - Compare the results of the operation with an expected result set.
    - Dispose of the underling direct memory when work is done.
    
    This code builds on that in DRILL-5324 to provide a complete row set
    API. See DRILL-5318 for the spec.
    
    Note: this code can be reviewed as-is, but cannot be committed until
    after DRILL-5324 is committed: this code has compile-time dependencies
    on that code. This PR will be rebased once DRILL-5324 is pulled into
    master.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message