drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #783: DRILL-5324: Provide simplified column reader/writer...
Date Tue, 14 Mar 2017 04:07:31 GMT
GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/783

    DRILL-5324: Provide simplified column reader/writer for use in tests

    The new "sub-operator" unit test framework provides simple ways to create row sets in
code. This PR includes the column accessor code:
    
    * Interfaces for column accessors
    * Template for generated implementations
    * Base implementation used by the generated code
    * Factory class to create the proper reader or writer given a major
    type (type and cardinality)
    * Utilities for generic access, type conversions, etc.
    
    Many vector types can be mapped to an int for get and set. One key
    exception are the decimal types: decimals, by definition, require a
    different representation. In Java, that is `BigDecimal`. Added get, set
    and setSafe accessors as required for each decimal type that uses
    `BigDecimal` to hold data.
    
    Work remains to be done on other complex types: intervals and so on.
    This will be added incrementally as work proceeds.
    
    The generated code builds on the `valueVectorTypes.tdd` file, adding
    additional properties needed to generate the accessors.
    
    The PR also includes a number of code cleanups done while reviewing
    existing code. In particular `DecimalUtility` was very roughly
    formatted and thus hard to follow.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-5324

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/783.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #783
    
----
commit eb0b8bc33aeea27fd0aae582d19297bd0bda92e1
Author: Paul Rogers <progers@maprtech.com>
Date:   2017-03-11T07:03:23Z

    The PR includes the column accessor code:
    
    * Interfaces described above
    * Generated implementations
    * Base implementation used by the generated code
    * Factory class to create the proper reader or writer given a major
    type (type and cardinality)
    * Utilities for generic access, type conversions, etc.
    
    Many vector types can be mapped to an int for get and set. One key
    exception are the decimal types: decimals, by definition, require a
    different representation. In Java, that is `BigDecimal`. Added get, set
    and setSafe accessors as required for each decimal type that uses
    `BigDecimal` to hold data.
    
    Work remains to be done on other complex types: intervals and so on.
    This will be added incrementally as work proceeds.
    
    The generated code builds on the `valueVectorTypes.tdd` file, adding
    additional properties needed to generate the accessors.
    
    The PR also includes a number of code cleanups done while reviewing
    existing code. In particular `DecimalUtility` was very roughly
    formatted and thus hard to follow.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message