drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request #781: DRILL-5351: Minimize bounds checking in var len vec...
Date Mon, 13 Mar 2017 22:47:32 GMT
GitHub user parthchandra opened a pull request:


    DRILL-5351: Minimize bounds checking in var len vectors for Parquet

    Two changes in var len vectors: 
    1) Instead of checking to see if we need to realloc for every setSafe call, let the write
fail and catch the exception. The exception, though expensive, will happen very rarely.
    2) Call fillEmpties only if there are empty values to fill. 
    This saves a bunch of CPU on every setSafe call.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/parthchandra/drill DRILL-5351

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #781
commit 57869496526a43351575d0f4879d2ac28fe973d4
Author: Parth Chandra <pchandra@maprtech.com>
Date:   2017-02-11T01:40:25Z

    DRILL-5351: Minimize bounds checking in var len vectors for Parquet


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message