drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #770: DRILL-5311: Check handshake result in C++ connector
Date Fri, 03 Mar 2017 04:42:39 GMT
GitHub user laurentgo opened a pull request:

    https://github.com/apache/drill/pull/770

    DRILL-5311: Check handshake result in C++ connector

    In C++ client connector, DrillClientImpl::recvHandshake always
    return success, even in case of connection error (like a tcp
    timeout issue). Only on WIN32 platform would the error code be
    checked.
    
    Remove the restriction to only check on WIN32, plus add some logging.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laurentgo/drill laurent/DRILL-5311

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/770.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #770
    
----
commit 23b7ca2fc082608b4d05faf8986644dc952e5830
Author: Laurent Goujon <laurent@dremio.com>
Date:   2017-03-03T04:38:05Z

    DRILL-5311: Check handshake result in C++ connector
    
    In C++ client connector, DrillClientImpl::recvHandshake always
    return success, even in case of connection error (like a tcp
    timeout issue). Only on WIN32 platform would the error code be
    checked.
    
    Remove the restriction to only check on WIN32, plus add some logging.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message