drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #704: DRILL-5125: Provide option to use generic code for ...
Date Thu, 30 Mar 2017 23:12:44 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/704#discussion_r109052570
  
    --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
    @@ -281,6 +282,11 @@ public void copyFromSafe(int fromIndex, int thisIndex, ${minor.class}Vector
from
         copyFrom(fromIndex, thisIndex, from);
       }
     
    +  @Override
    +  public void copyEntry(int toIndex, ValueVector from, int fromIndex) {
    --- End diff --
    
    From the name "copyEntry", it's not clear this new method will provide a semantics like
the existing method copyFrom(), or copyFromSafe(). 
    
    In value vector code, Drill's convention (in my understanding) is xxxSafe() means value
vector takes care of re-alloc() itself, in case of running out of buffer, while xxx() does
not have this guarantee. I think we had better follow this convention in new added method.

      


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message