drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #802: DRILL-5394: Optimize query planning for MapR-DB tab...
Date Thu, 30 Mar 2017 01:21:06 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/802#discussion_r108822541
  
    --- Diff: contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/binary/BinaryTableGroupScan.java
---
    @@ -174,7 +174,7 @@ public MapRDBSubScan getSpecificScan(int minorFragmentId) {
       @Override
       public ScanStats getScanStats() {
         //TODO: look at stats for this.
    -    long rowCount = (long) ((hbaseScanSpec.getFilter() != null ? .5 : 1) * tableStats.getNumRows());
    +    long rowCount = (long) ((hbaseScanSpec.getFilter() != null ? .5 : 1) * hbaseScanSpec.getRowCount());
    --- End diff --
    
    This code change would not be required if we use the alternative approach?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message