drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #801: DRILL-5378: Put more information for schema change ...
Date Tue, 28 Mar 2017 18:06:08 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/801#discussion_r108493803
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
    @@ -324,9 +328,9 @@ public AggOutcome doWork() {
                       logger.debug("Received new schema.  Batch has {} records.", incoming.getRecordCount());
                     }
     //                newSchema = true;
    -                this.cleanup();
                     // TODO: new schema case needs to be handled appropriately
    -                return AggOutcome.UPDATE_AGGREGATOR;
    +                this.cleanup();
    +                throw SchemaChangeException.schemChanged("Hash aggregate does not support
schema changes", schema, incoming.getSchema());
    --- End diff --
    
    Please correct to the renamed function here and elsewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message