drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #794: DRILL-5375: Nested loop join: return correct result...
Date Mon, 27 Mar 2017 16:05:20 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/794#discussion_r108210211
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/BatchReference.java
---
    @@ -0,0 +1,73 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to you under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.expr;
    +
    +import com.google.common.base.Preconditions;
    +
    +/**
    + * Holder class that contains batch naming, batch  and record index. Batch index is used
when batch is hyper container.
    + * Used to distinguish batches in non-equi conditions during expression materialization.
    + * Mostly used for nested loop join which allows non equi-join.
    + *
    + * Example:
    + * BatchReference{batchName='leftBatch', batchIndex='leftIndex', recordIndex='leftIndex'}
    + * BatchReference{batchName='rightContainer', batchIndex='rightBatchIndex', recordIndex='rightRecordIndexWithinBatch'}
    + *
    + */
    +public final class BatchReference {
    --- End diff --
    
    Can you add some comments about when the batch reference should be set ? for every batch
or once per OK_NEW_SCHEMA status ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message