drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #795: DRILL-5089: Get only partial schemas of relevant st...
Date Sun, 26 Mar 2017 05:46:24 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/795#discussion_r108050436
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
    @@ -144,6 +145,25 @@ public SchemaPlus getNewDefaultSchema() {
         return defaultSchema;
       }
     
    +  public SchemaPlus getPartialDefaultSchema() {
    +
    +    final String sessionSchemaPath = session.getDefaultSchemaPath();
    +    final List<String> schemaPathAsList = Lists.newArrayList(sessionSchemaPath.split("\\."));
    +
    +    final SchemaPlus rootSchema = schemaTreeProvider.createPartialRootSchema(getQueryUserName(),
    +        this, schemaPathAsList.get(0));
    +
    +    final SchemaPlus defaultSchema = session.getDefaultSchema(rootSchema);
    +
    +    if (defaultSchema == null) {
    +      return rootSchema;
    +    }
    +    return defaultSchema;
    +  }
    +
    +  public void addNewRelevantSchema(Set<String> storages, SchemaPlus toExpandSchema)
{
    --- End diff --
    
    `addNewSchema`? Presumably the schema is relevant of we'd not be adding it...
    
    If we are adding the schema, it is new to this context, so maybe just `addSchema`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message