drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #796: DRILL-5365: DrillFileSystem setConf in constructor....
Date Sun, 26 Mar 2017 01:15:34 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/796#discussion_r108049241
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/DrillFileSystem.java
---
    @@ -89,22 +89,36 @@ public DrillFileSystem(Configuration fsConf) throws IOException {
       }
     
       public DrillFileSystem(Configuration fsConf, OperatorStats operatorStats) throws IOException
{
    -    this.underlyingFs = FileSystem.get(fsConf);
    +    this(fsConf, URI.create(fsConf.getRaw(FS_DEFAULT_NAME_KEY)), operatorStats);
    +  }
    +
    +  public DrillFileSystem(Configuration fsConf, URI Uri, OperatorStats operatorStats)
throws IOException {
    --- End diff --
    
    This constructor is added to allow passing a URI. But, the rules for `FileSystem` (see
above), is that the URI is stored in the config as a property. So, is this constructor needed?
(One argument for using it is that the base class, `FileSystem`, does provide this form.)
    
    Also, this constructor is new. But there is no code in this PR that calls this constructor.
So, how does this new (unused) constructor fix the bug? Perhaps a bit of explanation would
clear up the mystery...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message