drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...
Date Tue, 21 Mar 2017 05:50:26 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r107077892
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
---
    @@ -262,6 +266,22 @@ public long getParquetRowGroupFilterPushDownThreshold() {
         return options.getOption(PARQUET_ROWGROUP_FILTER_PUSHDOWN_PLANNING_THRESHOLD);
       }
     
    +  /**
    +   * @return Quoting enum for current quoting identifiers character
    +   */
    +  public Quoting getQuotingIdentifiers() {
    --- End diff --
    
    use local var for `options.getOption(QUOTING_IDENTIFIERS)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message