drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #704: DRILL-5125: Provide option to use generic code for ...
Date Sat, 18 Mar 2017 20:43:00 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/704#discussion_r106790613
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/svremover/TestSVRemover.java
---
    @@ -34,4 +38,33 @@ public void testSVRWithNoFilter() throws Exception {
         int numOutputRecords = testPhysical(getFile("remover/sv_with_no_filter.json"));
         assertEquals(100, numOutputRecords);
       }
    +
    +  /**
    +   * Test the generic version of the selection vector remover copier
    +   * class. The code uses the traditional generated version by default.
    +   * This test sets the option to use the generic version, then runs
    +   * a query that exercises that version.
    +   * <p>
    +   * Note that the tests here exercise only the SV2 version of the
    +   * selection remover; no tests exist for the SV4 version.
    +   */
    +
    +  // TODO: Add an SV4 test once the improved mock data generator
    +  // is available.
    +
    +  @Test
    +  public void testGenericCopier() throws Exception {
    +    // TODO: replace this with new setup once revised test framework
    +    // is available.
    +    Properties config = new Properties( );
    +    config.put(ExecConstants.SYS_STORE_PROVIDER_LOCAL_ENABLE_WRITE, "false");
    +    config.put(ExecConstants.HTTP_ENABLE, "false");
    +    config.put(ExecConstants.REMOVER_ENABLE_GENERIC_COPIER, "true");
    +    updateTestCluster(1, DrillConfig.create(config));
    +
    +    int numOutputRecords = testPhysical(getFile("remover/test1.json"));
    +    assertEquals(50, numOutputRecords);
    +    numOutputRecords = testPhysical(getFile("remover/sv_with_no_filter.json"));
    +    assertEquals(100, numOutputRecords);
    +  }
     }
    --- End diff --
    
    No, which is why the feature is off by default. More work is needed to provide a reliable
way to generate data for all (supported) value vector types.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message