drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...
Date Wed, 15 Mar 2017 19:48:34 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r106265929
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
    @@ -184,6 +184,17 @@ private ServerMeta getServerMeta() throws SQLException {
         return serverMeta;
       }
     
    +  /**
    +   * The same as {@link DrillDatabaseMetaDataImpl#getServerMeta()} but updates server
metadata for the every call
    +   * @return server meta information
    +   * @throws SQLException for error when getting server meta
    +   */
    +  private ServerMeta getUpdatedServerMeta() throws SQLException {
    --- End diff --
    
    if you set quoting_identifier in the connection string, it's part of the session, and
metadata would return the correct value. But does it need to reflect it if user set it after
the connection is established and used? 
    Also, it seems the JDBC driver for SQLServer always return the default quoting: https://github.com/Microsoft/mssql-jdbc/blob/master/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java#L836


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message