drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...
Date Wed, 15 Mar 2017 19:37:13 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r106263502
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
    @@ -184,6 +184,17 @@ private ServerMeta getServerMeta() throws SQLException {
         return serverMeta;
       }
     
    +  /**
    +   * The same as {@link DrillDatabaseMetaDataImpl#getServerMeta()} but updates server
metadata for the every call
    +   * @return server meta information
    +   * @throws SQLException for error when getting server meta
    +   */
    +  private ServerMeta getUpdatedServerMeta() throws SQLException {
    --- End diff --
    
    SQL Server, for example, updates metadata in some cases
    https://www.mssqltips.com/sqlservertip/1415/determining-set-options-for-a-current-session-in-sql-server/
    Quoting_identifiers can be changes as system option. In this case any user can get the
right and actual quoting_identifiers method from server_metadata.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message