drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #777: DRILL-5330: NPE in FunctionImplementationRegistry
Date Sat, 11 Mar 2017 19:28:52 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/777#discussion_r105540304
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java
---
    @@ -133,7 +134,7 @@ public void resolveHash(DrillConfig config, LogicalExpression arg,
TypeProtos.Ma
                                         FunctionImplementationRegistry registry) throws JClassAlreadyExistsException,
IOException {
         final List<LogicalExpression> args = new ArrayList<>();
         args.add(arg);
    -    final String[] registeredNames = { "hash" };
    +//    final String[] registeredNames = { "hash" };
    --- End diff --
    
    Same reason. Removed this and the previous commented-out code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message