drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #777: DRILL-5330: NPE in FunctionImplementationRegistry
Date Sat, 11 Mar 2017 14:37:37 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/777#discussion_r105534412
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java
---
    @@ -62,10 +62,11 @@
     
     public class TestSimpleFunctions extends ExecTest {
       //private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(TestSimpleFunctions.class);
    -  private final DrillConfig c = DrillConfig.create();
    +//  private final DrillConfig c = DrillConfig.create();
    --- End diff --
    
    Why we need to comment this? If it's not need, can we just remove it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message