drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #772: DRILL-5316: Check drillbits size before we attempt ...
Date Wed, 08 Mar 2017 21:59:00 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/772#discussion_r105034016
  
    --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
    @@ -2143,6 +2146,9 @@ connectionStatus_t PooledDrillClientImpl::connect(const char* connStr,
DrillUser
                 Utils::shuffle(drillbits);
                 // The original shuffled order is maintained if we shuffle first and then
add any missing elements
                 Utils::add(m_drillbits, drillbits);
    +            if (m_drillbits.empty()){
    +                return handleConnError(CONN_FAILURE, getMessage(ERR_CONN_ZKNODBIT));
    --- End diff --
    
    can be done before the shuffle (it should not change the number of elements)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message